Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 2, 2024

To follow #2875, #2973, #2975, #3054, #3179, #3313, #3960

Resolves #2133

  • Eject CRA and use Parceljs for building the frontend
  • Also update to the latest: babel, eslint, jest, typescript

Cuts frontend / docker_build time from ~2:20 to ~1:20, but frontend / test_coverage time is still ~3:20.

(When testing this branch locally, npx jest --clearCache may be necessary if the frontend tests aren't working.)


This change is Reviewable

@imnasnainaec imnasnainaec added 🟨Medium Medium-priority PR and removed wip Work In Progress labels Oct 28, 2025
@imnasnainaec imnasnainaec marked this pull request as ready for review October 31, 2025 16:01
@imnasnainaec imnasnainaec changed the title Move from create-react-app to parcel + babel Move from create-react-app to parcel Oct 31, 2025
@jasonleenaylor
Copy link
Contributor

scripts/frontendScripts.js line 11 at r6 (raw file):

ensureFile(folder + "config.js");

// release.js with current version of The Combine

create release.js, or populate release.js with...

Code quote:

// release.js

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 24 of 28 files at r5, 11 of 11 files at r6, 3 of 3 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit e5bccbb into master Oct 31, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the parcel-babel-jest branch October 31, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend dependencies Pull requests that update a dependency file deployment docker documentation Improvements or additions to documentation frontend goal: CharacterInventory goal: ReviewEntries 🟨Medium Medium-priority PR python Size: L Large sized issue test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated middleware options

3 participants